Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICP-7369 Fix the ORVIBO smoke sensor status don't changed in ST app after trigger a smoke event #3746

Merged
merged 3 commits into from
Dec 6, 2018

Conversation

BYDengS
Copy link
Contributor

@BYDengS BYDengS commented Dec 6, 2018

@greens @MAblewiczS and @ALamchaS ,please help review this change.And merge it to China IOT Server. Thank you!.

@BYDengS
Copy link
Contributor Author

BYDengS commented Dec 6, 2018

Thanks @tpmanley help to solve this problem.

Hi Deng Biaoyi,

The issue is with IAS Zone enrollment. The older sensor sent a ZoneEnrollRequest shortly after it joined (timestamp 15.587418) and the hub responded with a successful ZoneEnrollResponse (timestamp 16.621316). After that point the device is enrolled and able to generate alarm events. The new sensor does not send a ZoneEnrollRequest during joining so it does not get enrolled in an IAS Zone and so it does not generate alarm events.

Most IAS Zone devices work the way this new version of the sensor works, in that they do not send a ZoneEnrollRequest automatically. Instead they rely on the DTH to send a ZoneEnrollResponse (not a ZoneEnrollRequest), and write the CIE Address attribute in the configure method.

Here is how I'd suggest updating the configure method:

def configure() {
log.debug "configure"sendEvent(name: "checkInterval", value:6 * 60 * 60 + 2 * 60, displayed: false, data: [protocol: "zigbee", hubHardwareId: device.hub.hardwareID, offlinePingable: "1"])

return refresh() + zigbee.enrollResponse() + zigbee.configureReporting(zigbee.POWER_CONFIGURATION_CLUSTER, 0x0021, DataType.UINT8, 30, 21600, 0x10)

}

The reason I moved refresh to the beginning is will decrease the amount of time it takes to get the initial status for battery and zoneStatus. The additional call to zigbee.enrollResponse() will take care of writing the CIE address and sending the ZoneEnrollResponse to get the device enrolled in the IAS Zone. Please give this change a try and see if it fixes the problem.

Best regards,
Tom

@BYDengS BYDengS changed the title ICP 7369 Fix the smoke sensor status don't changed in ST app after trigger a smoke event ICP 7369 Fix the ORVIBO smoke sensor status don't changed in ST app after trigger a smoke event Dec 6, 2018
@tpmanley tpmanley merged commit 86b63c4 into SmartThingsCommunity:master Dec 6, 2018
@tpmanley
Copy link
Contributor

tpmanley commented Dec 6, 2018

This has been deployed to PROD and STG

@greens greens changed the title ICP 7369 Fix the ORVIBO smoke sensor status don't changed in ST app after trigger a smoke event ICP-7369 Fix the ORVIBO smoke sensor status don't changed in ST app after trigger a smoke event Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants