Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Fix template/package.json to a specific version of Electron #60

Closed
wants to merge 1 commit into from
Closed

Fix template/package.json to a specific version of Electron #60

wants to merge 1 commit into from

Conversation

JanCVanB
Copy link
Contributor

@JanCVanB JanCVanB commented Nov 7, 2016

The Electron docs recommend referencing a specific version of Electron, as Electron does not follow Semantic Versioning:
http://electron.atom.io/docs/tutorial/electron-versioning/

@SimulatedGREG
Copy link
Owner

@JanCVanB

http://electron.atom.io/docs/tutorial/electron-versioning/
If you are using electron or electron-prebuilt, we recommend that you set a fixed version number (1.1.0 instead of^1.1.0) to ensure that all upgrades of Electron are a manual operation made by you, the developer.

Thanks for the PR, but I'll have to reject this (sorry). This falls into the category of what the developer should do with their app. electron-vue is purely a template and should always provide the latest version of its dependencies. Defining a fixed version would mean you would have to continually update the template every time a new release comes out. This might be worth noting within the documentation though.

@JanCVanB
Copy link
Contributor Author

JanCVanB commented Nov 7, 2016

Understood - do you have any plans to upgrade the template's dependencies soon, considering Electron's on v1.4.5?

@SimulatedGREG
Copy link
Owner

@JanCVanB

There's no current need to manually update dependencies at this time since nearly all use the Caret notation. In other words, since electron is set to use ^1.3.1, npm knows to look for the latest 1.x.x release. Running a npm ls electron on a freshly scaffolded project of electron-vue will show that the electron version is already at 1.4.5.

Caret Ranges
Allows changes that do not modify the left-most non-zero digit in the [major, minor, patch] tuple. In other words, this allows patch and minor updates for versions 1.0.0 and above, patch updates for versions 0.X >=0.1.0, and no updates for versions 0.0.X.
-- npm docs

SimulatedGREG added a commit that referenced this pull request Nov 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants