Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent/execute_code): Disable code execution commands when Docker is unavailable #6888

Conversation

kcze
Copy link
Contributor

@kcze kcze commented Feb 21, 2024

Background

Fix

Changes 🏗️

  • Disable execute_python_code and execute_python_file if running outside Docker and Docker is unavailable.

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@kcze kcze requested a review from Pwuts as a code owner February 21, 2024 14:44
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 5ed75c9
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/65de4592f756ac00088983fb
😎 Deploy Preview https://deploy-preview-6888--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kcze kcze requested a review from a team as a code owner February 27, 2024 20:26
@kcze kcze requested a review from Pwuts February 27, 2024 20:28
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Pwuts Pwuts changed the title OPEN-138: Fix: disable code execution command when Docker is unavailable fix(agent/execute_code): Disable code execution commands when Docker is unavailable Feb 28, 2024
@Pwuts Pwuts merged commit 30762c2 into Significant-Gravitas:master Feb 28, 2024
10 of 13 checks passed
@Pwuts
Copy link
Member

Pwuts commented Feb 28, 2024

A nice addition would be to display a warning when starting the application, because users might still expect it to work.

@kcze kcze deleted the kpczerwinski/open-138-could-not-run-the-script-in-a-container branch February 28, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants