Feat: QS: query builder suggestions api v0 #5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-k-singh
force-pushed
the
feat/query-builder-suggestions-qs-api-0
branch
from
e296e5c
to
7727f48
Compare
raj-k-singh
force-pushed
the
feat/query-builder-suggestions-qs-api-0
branch
from
c040bc9
to
a4268a6
Compare
raj-k-singh
commented
Aug 6, 2024
…bs already used in filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First version of /api/v3/filter_suggestions based on existing autocomplete approaches.
This change unblocks integration with and testing of UI changes for filter suggestions and unblocks shipping of the feature.
More sophisticated suggestion strategies will be added in follow up changes.
Design for filter suggestions: https://www.notion.so/signoz/Query-Builder-84ca8065578f4d31a82ae7c9ba1f2353?pvs=4#cb405262a68247dba9a84cfdfc09a049
API contract for filter suggestions: https://www.notion.so/signoz/api-v3-suggestions-8fe44f11ac1348f0bff7b1441d382f83
Related Issues / PR's
Contributes to #5609
Affected Areas and Manually Tested Areas
No existing functionality is affected by this change