Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use selected columns as pinned attributes #5601

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Jul 29, 2024

Summary

  • treat the selected columns as the pinned attributes for the logs details drawer
  • this should be the sole way to pin attributes hence removed the pin options from the logs detail drawer

Related Issues / PR's

fixes #4577

Screenshots

NA

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Jul 29, 2024
@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review July 29, 2024 19:48
SagarRajput-7
SagarRajput-7 previously approved these changes Aug 1, 2024
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikrantgupta25 vikrantgupta25 merged commit f3d73f6 into develop Aug 12, 2024
11 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the selected-columns-as-pinned branch August 12, 2024 11:04
raj-k-singh pushed a commit that referenced this pull request Aug 15, 2024
* feat: use selected columns as pinned attributes

* chore: handle nested json structs

* chore: refactor and fix build issues

* feat: handle changes for dashboard list panel

* chore: remove console logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOGS[FE]: Use selected column/attribute as pinned attributes.
4 participants