Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update the md file for integrations config #4677

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: update the md file for integrations config #4677

merged 1 commit into from
Mar 11, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Mar 11, 2024 •
edited
Loading

Summary

  • update the .md file for the integrations config.
  • the markdown styling are dependent on the bash script being present in the code blocks

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the bug Something isn't working label Mar 11, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit a4d5774 into develop Mar 11, 2024
10 of 13 checks passed
@raj-k-singh
Copy link
Collaborator

raj-k-singh commented Mar 11, 2024 •
edited
Loading

LGTM 👍
Do all code blocks need to have bash annotation or should it be content specific? Eg: Should yaml blocks have yaml etc?

@vikrantgupta25 vikrantgupta25 deleted the integrations-config branch March 11, 2024 07:29
@vikrantgupta25
Copy link
Collaborator Author

LGTM 👍
Do all code blocks need to have bash annotation or should it be content specific? Eg: Should yaml blocks have yaml etc?

We have yaml as well, we can check this once we start finalising the config, will share the details with you soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikrantgupta25 @raj-k-singh @YounixM