Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: frontend: log pipelines preview #3706

Merged
merged 19 commits into from
Oct 12, 2023

Conversation

raj-k-singh
Copy link
Collaborator

@raj-k-singh raj-k-singh commented Oct 10, 2023

Contributes to #3509

Adds UI for previewing pipeline processing as shown below.

pipeline-preview-0

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@request-info
Copy link

request-info bot commented Oct 10, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@palashgdev
Copy link
Contributor

can we use the RawView in the modal... seems like typography is used ...

@raj-k-singh
Copy link
Collaborator Author

can we use the RawView in the modal... seems like typography is used ...

I did a quick attempt at using RawLogView for displaying the sample and result logs, but it was appearing too big in size and will need some more attention to get it looking right.

The raw log view is indeed promising for use here. I will take this enhancement up in a follow up PR.

@raj-k-singh raj-k-singh changed the title frontend: log pipelines preview feat: frontend: log pipelines preview Oct 11, 2023
@github-actions github-actions bot added the enhancement New feature or request label Oct 11, 2023
@raj-k-singh raj-k-singh force-pushed the feat/frontend-logpipelines-preview branch from 9b79203 to 90e9c6b Compare October 11, 2023 11:11
@raj-k-singh raj-k-singh force-pushed the feat/frontend-logpipelines-preview branch from 90e9c6b to 23d0fe0 Compare October 11, 2023 12:11
Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raj-k-singh raj-k-singh merged commit 2be3d35 into develop Oct 12, 2023
11 checks passed
@raj-k-singh raj-k-singh deleted the feat/frontend-logpipelines-preview branch October 12, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request request-more-info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants