Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 10.12_machine-translation.md #64

Closed
wants to merge 1 commit into from
Closed

Update 10.12_machine-translation.md #64

wants to merge 1 commit into from

Conversation

10yuan
Copy link

@10yuan 10yuan commented Nov 25, 2019

No description provided.

@ShusenTang
Copy link
Owner

PR的原因是？

@10yuan
Copy link
Author

10yuan commented Nov 26, 2019

修正的代码的小问题
１．背景向量ｃ的尺描述不对．原代码设置的num_hiddens, embed_size都设为64，不会报错．实际ｃ的shape为（批量大小, 隐藏单元个数)
２．mask的更新方式

ShusenTang added a commit that referenced this pull request Nov 26, 2019
@ShusenTang
fix bug(#64), update mask, fix typo
a86f344
@ShusenTang
Copy link
Owner

修正的代码的小问题
１．背景向量ｃ的尺描述不对．原代码设置的num_hiddens, embed_size都设为64，不会报错．实际ｃ的shape为（批量大小, 隐藏单元个数)
２．mask的更新方式

嗯，我仔细看了一下那个维度确实不对，应该是 num_hiddens + embed_size。至于那个mask，原书的那种写法是对的，所以我保持原书的写法

@ShusenTang ShusenTang closed this Nov 26, 2019
@ShusenTang ShusenTang mentioned this pull request Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@10yuan @ShusenTang