Add api versions for url prefix control #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,8 +66,9 @@ def encoded_params_for_signature(params) | |||
| end | |||
| end | |||
|
|
|||
| def initialize(url, token = nil, extra = {}) | |||
| def initialize(url, token = nil, api_version = :no_version, extra = {}) | |||
There was a problem hiding this comment.
Could api_version be a kwarg? Same q for temp.
There was a problem hiding this comment.
compatibility is my biggest concern with that.
There was a problem hiding this comment.
But couldn't a kwarg just have a default, too?
There was a problem hiding this comment.
could you provide the full signature you are picturing?
There was a problem hiding this comment.
Converged on "maybe it is better to just go to keyword args", i.e. def initialize(url:, token:, api_version:, ...)
There was a problem hiding this comment.
The method signature will change in the next PR, in which api_version becomes required.
alexaitken
force-pushed
the
add-api-versions-for-url-prefix-control
branch
3 times, most recently
from
eeddd7a
to
730eae1
Compare
chrisbutcher
approved these changes
Apr 1, 2019
alexaitken
force-pushed
the
add-api-versions-for-url-prefix-control
branch
from
730eae1
to
98cd7ba
Compare
tylerball
approved these changes
Apr 1, 2019
alexaitken
force-pushed
the
add-api-versions-for-url-prefix-control
branch
from
98cd7ba
to
333787d
Compare
alexaitken
force-pushed
the
add-api-versions-for-url-prefix-control
branch
from
333787d
to
1887de8
Compare
tylerball
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add api version to control the url prefix of both the graphql schema and rest resources.
Coercion support from strings and symbols of all the defined api versions.
The version has been added to the ShopifyAPI::Base as a thread safe attribute when that is available.
It is also added to the session and defaulted to
no_versionto match current behaviour.Session usage looks like:
ShopifyAPI::Session.new("https://this-is-my-test-shop.myshopify.com", "test_token", :no_version)ShopifyAPI::Session.new("https://this-is-my-test-shop.myshopify.com", "test_token", 'unstable')