Ruby dependencies should only be invoked when the legacy flag is passed #4460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Ruby dependencies should only be invoked when the legacy flag is passed. However, users receive the following message when they try to invoke
shopify theme dev
.WHAT is this pull request doing?
When the
--legacy
flag is not passed, it defaults toundefined
, and then the mechanism that refreshes the session is invoked. This regression was introduced after the dev preview when we inverted the logic from--dev-preview
to--legacy
.How to test your changes?
shopify theme dev
Post-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist