Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby dependencies should only be invoked when the legacy flag is passed #4460

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

karreiro
Copy link
Contributor

WHY are these changes introduced?

Ruby dependencies should only be invoked when the legacy flag is passed. However, users receive the following message when they try to invoke shopify theme dev.

WHAT is this pull request doing?

When the --legacy flag is not passed, it defaults to undefined, and then the mechanism that refreshes the session is invoked. This regression was introduced after the dev preview when we inverted the logic from --dev-preview to --legacy.

How to test your changes?

  • Run shopify theme dev

Post-release steps

N/A

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73% (+0.01% 🔼)
8389/11491
🟡 Branches
69.56% (+0.02% 🔼)
4091/5881
🟡 Functions 71.75% 2179/3037
🟡 Lines
73.35% (+0.01% 🔼)
7938/10822

Test suite run success

1889 tests passing in 857 suites.

Report generated by 🧪jest coverage report action from e41f21f

@isaacroldan isaacroldan merged commit 810fd57 into main Sep 17, 2024
37 checks passed
@isaacroldan isaacroldan deleted the theme-dev-legacy branch September 17, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants