-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Functions] Bump javy to 3.1.0 #4444
Conversation
This commit bumps `javy` to v3.1.0 and ammends the new commands to be used by `javy` to build functions.
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Test suite run success1863 tests passing in 847 suites. Report generated by 🧪jest coverage report action from 3dad45a |
While tophatting, I ran into this issue while running the function:
Not sure if this is just due to running from source, looking into it. Seems unlikely to be related to this PR. function-runner version: |
|
Can't replicate the issue on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tophat unsuccessful, just marking this as reviewed so I'm properly notified when you want me to look again.
Happy to pair or slack through this as well if needed.
This hints to me that your |
Yep, that did it 👍 And I assume that won't be an issue for devs since it'll start out with a fresh bin on a new version |
Yeah, that's correct. |
Getting to a build without issue, but I'm not getting the |
I noticed that the version of javy in the generated extension is only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tophatted with Saul- for a yet unknown reason, we needed to invoke the CLI using node ../packages/cli/bin/dev.js
, not p shopify
, that solved the issue I was having
WHY are these changes introduced?
This commit bumps
javy
to v3.1.0 and ammends the new commands to be used byjavy
to build functions.How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist