Fixed some more issues + Mods folder stuff #15422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the grpWeekText.length check to weeksList.length so it doesn't crash anymore. (for real this time) - Fixed the cancelMenu sound not playing when going back from both menus. - Fixed the softlock when you try to load a week with no chart for the first song.
- Fixed character animation offsets breaking when the character's scale is changed.
- Fixed a compiling issue with MODS_ALLOWED disabled by importing openfl.Assets where it's needed.
- Auto delete the mods folder when MODS_ALLOWED is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I redid the storymode weekList fix i did, so it should work properly now 😅.
More info of what i did is in the description of each commit.
(The action checks will probably fail because of the most recent commit as of the time of this PR. I didn't bother to revert that commit here in case someone was fixing it)