Fix Loading State #15386
Merged
Fix Loading State #15386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan2008Git
approved these changes
Aug 29, 2024
DMMaster636
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mutex in the loading state was used in a wrong way. It was acquired at the beggining of the thread and only released at the end of the thread, which basically just blocked all other threads from working.
So this pr uses the mutex only when necessary, meaning only when needing to update shared variables.
I did do a small test to see if performance is better, and it seems to be better.
CPU: i7 870 (8 logical processors)
Before the fix loading Bopeebo took 1.8 seconds
After the fix loading Bopeebo took 0.2 seconds
I only tested it once, so take the benchmark with a grain of salt.