Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Function_Stop on note callbacks and add noteMissPre #15234

Open
wants to merge 5 commits into
base: experimental
Choose a base branch
from
Open

Fix Function_Stop on note callbacks and add noteMissPre #15234

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5569ff
Fix Function_Stop on note callbacks and add noteMissPre
LarryFrosty Aug 3, 2024
e230a6a
little eventEarlyTrigger fix
LarryFrosty Sep 7, 2024
87b7da2
wrong branch also i realized that was already fixed LOL
LarryFrosty Sep 7, 2024
e5f8a4f
add this back
LarryFrosty Sep 15, 2024
46a1ac5
check Function_StopHScript/All on "pre" functions
LarryFrosty Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wrong branch also i realized that was already fixed LOL
  • Loading branch information
@LarryFrosty
LarryFrosty committed Sep 7, 2024
commit 87b7da286362f03e9ea4ddd079c683777e6b1ad9
12 changes: 6 additions & 6 deletions source/states/PlayState.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,12 @@ class PlayState extends MusicBeatState
noteTypes = null;
eventsPushed = null;

if(eventNotes.length > 1)
{
for (event in eventNotes) event.strumTime -= eventEarlyTrigger(event);
eventNotes.sort(sortByTime);
}

// SONG SPECIFIC SCRIPTS
#if (LUA_ALLOWED || HSCRIPT_ALLOWED)
for (folder in Mods.directoriesWithFile(Paths.getSharedPath(), 'data/$songName/'))
Expand All @@ -582,12 +588,6 @@ class PlayState extends MusicBeatState
}
#end

if(eventNotes.length > 0)
{
for (event in eventNotes) event.strumTime -= eventEarlyTrigger(event);
eventNotes.sort(sortByTime);
}

startCallback();
RecalculateRating();

Expand Down
Loading