Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some lua improvements #15088

Open
wants to merge 25 commits into
base: experimental
Choose a base branch
from
Open

Some lua improvements #15088

wants to merge 25 commits into from

Conversation

LarryFrosty
Copy link
Contributor

@LarryFrosty LarryFrosty commented Jul 12, 2024 •
edited
Loading

Additions:

  • Added removeVar
  • Added the group argument to setObjectOrder and getObjectOrder
  • Added support for GF to cameraSetTarget

Changes:

  • Most "set" functions that didn't return the value now return the value for convenience
    • List of functions include:
      setScore, setMisses, setHits, setHealth, setCharacterX, setCharacterY, setRatingPercent, setRatingName, setRatingFC
  • loadSong now mutes opponent vocals.
  • getRunningScripts now includes HScripts

Fixes:

  • Fixed createCallback's 3rd argument only taking it as a valid instance if parentLua isn't null, which made this function practically useless on .hx files
  • Fixed getLuaTween returning a null error if options aren't present
  • getScreenPositionX and getScreenPositionY now use the camera argument
  • Fixed a typo on setPropertyFromClass and createInstance error messages

This was referenced Jul 12, 2024
Closed
Closed
@LarryFrosty
oops
0eec272 
after like months from my first pr about cameraSetTarget i only realized now why it errors
@LarryFrosty
you sure it was tested?
cddf75b
@LarryFrosty
hm
a352227
@LarryFrosty LarryFrosty reopened this Aug 23, 2024
@LarryFrosty
poop
dddb6f3
@LarryFrosty
revert to pre 1.0
272f05e 
should make github think im not changing this part of the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodney528 rodney528 rodney528 approved these changes

@system32unknown system32unknown system32unknown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LarryFrosty @rodney528 @system32unknown