Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hscript-improved #13304

Closed

Conversation

TheLeerName
Copy link
Contributor

@TheLeerName TheLeerName commented Sep 19, 2023

as u can see in this repo, SScript is not exists anymore, so i got idea implement hscript-improved lib from Codename Engine cuz it have the same things as in SScript like import and such

So now with this library we can use this script:

function onCreatePost() {
	gf.visible = false;
}

and yes, as you can see, we can avoid using game variable 😱
classes still bugged and dont work normally (skill issue)
also i rewritted error messages (lol as in #13017), and i know about bug with duplicated file name in haxe 4.3.X lol
also getTextFromFile lua function and Paths.getTextFromFile now has 3rd argument, if it true, then it gets file by absolute path
also addHaxeLibrary can import enums now

UPD: 17:49 - 19.09.2023

  • errors on hscript now traces to console
  • if u got error in runHaxeCode, it stops executing
  • Lua_helper.add_callback() now just set()
  • setOnLuas now not crashes when u trying to set function with it
  • trace of elapsed time after loading script

WARNING: USE THIS COMMAND BEFORE COMPILING PLS

haxelib git hscript-improved https://github.com/TheLeerName/hscript-improved

will use original hscript-improved if my pr in original repo will be merged

using my fork cuz it can compile

WARNING: USE THESE COMMANDS BEFORE COMPILING PLS
haxelib remove hscript
haxelib git hscript https://github.com/TheLeerName/hscript-improved
Copy link
Contributor

@DetectiveBaldi DetectiveBaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

TheLeerName added a commit to TheLeerName/fearful-fridays that referenced this pull request Sep 19, 2023
will fix rejection shaders

from my cool pr!!!!!!!
ShadowMario/FNF-PsychEngine#13304
Copy link

@charlesisfeline charlesisfeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea creator of sscript deleted their account for some reason and that may make future commits not able to compile in this condition so ig this should do

backward compatibility
@TheLeerName
Copy link
Contributor Author

bro got Http Error #502

Copy link
Contributor

@mcagabe19 mcagabe19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yea

Copy link

@frantastic24 frantastic24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work with no problems
thank god because sscript just kept getting worse and worse

@charlesisfeline
Copy link

charlesisfeline commented Sep 23, 2023

oh btw you might just close this cuz the brewscript pr got merged

@TheLeerName
Copy link
Contributor Author

TheLeerName commented Sep 23, 2023

as BrewScript already implemented im closing this, but i copied some changes to another prs:
#13325
#13326

@TerminallyAwesome
Copy link

still doesnt work for me

@moxie-coder
Copy link

still doesnt work for me

install brewscript

@TerminallyAwesome
Copy link

nevermind I just got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants