Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Commit

Permalink
Add TODO to remove classes after migration to configurable attributes
Browse files Browse the repository at this point in the history
Reviewed By: bobyangyf

fbshipit-source-id: 33563d7534
  • Loading branch information
Sergey Tyurin authored and facebook-github-bot committed Mar 22, 2019
1 parent f17e820 commit a71fb56
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/com/facebook/buck/parser/DefaultParser.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
* <p>Computed targets are cached but are automatically invalidated if Watchman reports any
* filesystem changes that may affect computed results.
*/
// TODO: remove after migration to configurable attributes
class DefaultParser extends AbstractParser {

private static final Logger LOG = Logger.get(Parser.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
* This factory creates {@link PerBuildStateFactory} that uses simple pipeline that doesn't support
* configurable attributes.
*/
// TODO: remove after migration to configurable attributes
class LegacyPerBuildStateFactory extends PerBuildStateFactory {
private final TypeCoercerFactory typeCoercerFactory;
private final ConstructorArgMarshaller marshaller;
Expand Down
1 change: 1 addition & 0 deletions src/com/facebook/buck/parser/TargetNodeParsePipeline.java
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
* duplicated (the **JobsCache variables) are used to make sure we don't schedule the same work more
* than once), however it's possible for multiple read-only commands to duplicate work.
*/
// TODO: remove after migration to configurable attributes
@ThreadSafe
public class TargetNodeParsePipeline
extends ConvertingPipeline<Map<String, Object>, TargetNode<?>> {
Expand Down

0 comments on commit a71fb56

Please sign in to comment.