Fixing and testing into_json of various field types
#539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
force-pushed
the
into-json-fixup
branch
2 times, most recently
from
11e36b2
to
2157712
Compare
billy1624
force-pushed
the
into-json-fixup
branch
from
2157712
to
ddf1e23
Compare
|
Additional test cases: UUID is also missing when using into_json. |
|
I guess this is still a WIP? @billy1624 |
Hey @yashsamit, good observations! UUID is missing because there is no way to know it's a UUID column on |
billy1624
force-pushed
the
into-json-fixup
branch
from
9632d50
to
fe72cd9
Compare
Ready for review |
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Fixes
The
into_jsonmethod does not handle custom types such aschrono,serde_jsonandrust_decimal. As a result some JSON keys will be in the resulting JSON object.