Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Timer App with Brand Fetching Features. #181

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

New Timer App with Brand Fetching Features. #181

wants to merge 19 commits into from

Conversation

salmanfarisvp
Copy link
Collaborator

@salmanfarisvp salmanfarisvp commented Aug 30, 2024 •
edited
Loading

Update the new timer app with new brand features.

image

  • Update the colours as per the brand's primary and secondary colours
  • Update the Brand logo and apply it to the timer app
  • Override time zone
  • Override locale setting for region languages in dates.
  • Support Standard Screen Sizes - As per Supported Screen Resolutions
  • Tracks/captures errors using Sentry
  • Added Signal Ready
  • QA done by at least two or more members.

@salmanfarisvp salmanfarisvp marked this pull request as ready for review September 2, 2024 02:41
@iamplugged
Copy link
Contributor

@salmanfarisvp A couple of comments. Looks good otherwise.

@salmanfarisvp
Copy link
Collaborator Author

I found an issue with CSS on RPI screens and am working on the fix now.

@salmanfarisvp salmanfarisvp self-assigned this Oct 2, 2024
@salmanfarisvp
Copy link
Collaborator Author

I found an issue with CSS on RPI screens and am working on the fix now.

It was a chrome issue, not the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamplugged iamplugged iamplugged approved these changes

Assignees

@salmanfarisvp salmanfarisvp

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salmanfarisvp @iamplugged