Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDA for callbacks that change p #448

Merged

Conversation

oscardssmith
Copy link
Contributor

@oscardssmith oscardssmith commented Feb 6, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
Requires SciML/DiffEqBase.jl#997 for tests to pass. Fixes #449

@ChrisRackauckas
Copy link
Member

Test fails?

@oscardssmith
Copy link
Contributor Author

yes. the test relies on your diffeqbase pr to make the reinit happen in the first place

@oscardssmith
Copy link
Contributor Author

I believe tests should now pass.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce4753f) 81.67% compared to head (3024c4a) 81.90%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   81.67%   81.90%   +0.22%     
==========================================
  Files          11       11              
  Lines        1468     1470       +2     
==========================================
+ Hits         1199     1204       +5     
+ Misses        269      266       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 419083a into SciML:master Feb 15, 2024
6 of 11 checks passed
@oscardssmith oscardssmith deleted the os/fix-p-change-in-callback branch February 15, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDA fails to solve when encountering algebraically inconsistent u after callback
2 participants