Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the saveat and tstop handling match OrdinaryDiffEq more closely #436

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

oscardssmith
Copy link
Contributor

and remove bug where we would pretend to hit tstops when not actually doing so. Specifically, the check of while integrator.tdir * (integrator.t - first(integrator.opts.tstops)) < -1e6eps() meant that tstops would be ignored if the solver happened to be close to the time that the solver happened to step. I'm not 100% sure that the issue the comment was warning about is gone (partly because the comment appears to have been cut off in the middle), but I suspect that the if integrator.t == integrator.tprev check that I added a few months ago may have fixed it.

…and remove bug where we would pretend to hit tstops when not actually doing so
@ChrisRackauckas
Copy link
Member

Tests really don't seem to like this 😓

@oscardssmith
Copy link
Contributor Author

yeah. I was missing a few signs. This will hopefully work now.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (81fb59a) 81.80% compared to head (7d21bfb) 81.66%.
Report is 4 commits behind head on master.

Files Patch % Lines
src/common_interface/integrator_utils.jl 33.33% 2 Missing ⚠️
src/common_interface/solve.jl 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
- Coverage   81.80%   81.66%   -0.14%     
==========================================
  Files          11       11              
  Lines        1440     1440              
==========================================
- Hits         1178     1176       -2     
- Misses        262      264       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 7dac95d into SciML:master Nov 21, 2023
4 of 6 checks passed
@oscardssmith oscardssmith deleted the os/unify-tstop-handling branch November 21, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants