Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add immutable ODE Problem for GPU compilation #306

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

utkarsh530
Copy link
Member

@ChrisRackauckas I am not very fond of having ImmutableODEProblem as it cannot be kept entirely internal. We need to expose some implementation in the lower-level API case. We should probably tag this as a breaking release.

@ChrisRackauckas
Copy link
Member

Yeah... this is only meant to be temporary to appease @wsmoses

@wsmoses
Copy link

wsmoses commented Oct 19, 2023

Yeah the reason it needed to be mutable is because otherwise there's a mixedactivity state when differentiating it since it contains both pointer-to-float data [aka vector{float64}] and a float64, meaning there's no single (either via in place since mutable, or via return since its immutable) way to update it.

We've been working on some big type-based activity analysis things that just landed, so it may be time in the near future for us to look at a better workaround.

@ChrisRackauckas ChrisRackauckas merged commit 76f8431 into master Oct 19, 2023
9 of 12 checks passed
@ChrisRackauckas ChrisRackauckas deleted the u/immutablefix branch October 19, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants