Skip to content

Commit

Permalink
pkgdep: Install git at the default /usr/local/bin dir
Browse files Browse the repository at this point in the history
There's no point in keeping track of the extra path and pollute the
global bash profiles with it. Just put the target binary under the
/usr/local/bin which most distros, including centos7 keep in their
$PATH.

Also, drop the proxyconf mention as we are not using it anymore.

Signed-off-by: Michal Berger <[email protected]>
Change-Id: I2a531fb140aea4c87ad8c3f053a39d262d2d02ae
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16853
Reviewed-by: Tomasz Zawadzki <[email protected]>
Tested-by: SPDK CI Jenkins <[email protected]>
Reviewed-by: Jim Harris <[email protected]>
Reviewed-by: Pawel Piatek <[email protected]>
  • Loading branch information
mikeBashStuff authored and tomzawadzki committed Feb 22, 2023
1 parent 4dcb944 commit ea91da8
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions test/common/config/pkgdep/git
Original file line number Diff line number Diff line change
Expand Up @@ -346,12 +346,8 @@ function install_git() {
tar -C "$GIT_REPOS" -xzof <(wget -qO- "$GIT_REPO_GIT")
(cd "$GIT_REPOS/git-$GIT_VERSION" \
&& make configure \
&& ./configure --prefix=/usr/local/git \
&& ./configure \
&& sudo make -j${jobs} install)
sudo sh -c "echo 'export PATH=/usr/local/git/bin:$PATH' >> /etc/bashrc"
export "PATH=/usr/local/git/bin:$PATH"
# Be nice for vagrant-proxyconf setup
mkdir -p "/usr/local/git/etc"
}

function install_extra_pkgs() {
Expand Down

0 comments on commit ea91da8

Please sign in to comment.