Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept-language in HTTP header is set to en-US,en and cannot be changed, despite SEB being in a different language #194

Closed
Sturek opened this issue Sep 9, 2021 · 2 comments
Assignees
Labels
enhancement This issue proposes an enhancement of the software.
Milestone

Comments

@Sturek
Copy link

Sturek commented Sep 9, 2021

Describe the Bug
While the SEB interface is localized, "accept-language" in the HTTP header is set to "en-US, en" and websites are, thus, defaulting to English.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Set your system to a language other than English.
  2. Configure the SEB to go to a page displaying the HTTP header, such as: https://manytools.org/http-html-text/http-request-headers/
  3. Start the SEB
  4. Compare the language of the interface to the accept-language value in the HTTP header.

Expected Behavior
Expected behavior would be that the language passed to the website in the HTTP header is the same as the language of the SEB interface.

Screenshots
Screenshot 2021-09-09 155237

Version Information

  • OS: Windows 10 Pro, 21H1
  • SEB-Version 3.3.0

Additional Context
This may be due to CefSettings.AcceptLanguageList not being set in BrowserApplication.cs and defaulting to en-US,en, as per https://cefsharp.github.io/api/83.4.x/html/P_CefSharp_CefSettingsBase_AcceptLanguageList.htm . May be related to this unresolved, closed issue.

@dbuechel
Copy link
Member

Thanks for your report. We'll see that we can fix this with the next version.

@dbuechel dbuechel added the enhancement This issue proposes an enhancement of the software. label Sep 23, 2021
@dbuechel dbuechel added this to the 3.4.0 milestone Oct 8, 2021
@dbuechel dbuechel changed the title Accept-language in HTTTP header is set to en-US,en and cannot be changed, despite SEB being in a different language Accept-language in HTTP header is set to en-US,en and cannot be changed, despite SEB being in a different language Nov 10, 2021
@dbuechel dbuechel modified the milestones: 3.4.0, 3.3.2 Nov 10, 2021
dbuechel added a commit that referenced this issue Dec 23, 2021
@dbuechel
Copy link
Member

dbuechel commented Jan 5, 2022

The issue should be fixed and works according to our testing. You can review the change in the latest beta build if you wish.

@dbuechel dbuechel closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue proposes an enhancement of the software.
Projects
None yet
Development

No branches or pull requests

2 participants