improve addons (ueman#129)

SVyatoslavG · Oct 22, 2021 · 1d8969b · 1d8969b
1 parent 69d06e9
commit 1d8969b
Show file tree

Hide file tree

Showing 8 changed files with 44 additions and 15 deletions.
diff --git a/.github/workflows/gitlab.yml b/.github/workflows/gitlab.yml
@@ -30,5 +30,4 @@ jobs:
       - run: flutter pub get
       - run: flutter format -n --set-exit-if-changed .
       - run: flutter analyze
-      - run: flutter test --coverage
-      - uses: codecov/[email protected]
+      - run: flutter test
diff --git a/.github/workflows/sentry.yml b/.github/workflows/sentry.yml
@@ -30,5 +30,4 @@ jobs:
       - run: flutter pub get
       - run: flutter format -n --set-exit-if-changed .
       - run: flutter analyze
-      - run: flutter test --coverage
-      - uses: codecov/[email protected]
+      - run: flutter test
diff --git a/feedback_gitlab/CHANGELOG.md b/feedback_gitlab/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 2.2.0
+
+* This update is compatible with feedback 2.2.0
+* Improve documentation
+
 ## 2.0.0+1
 
 * Update Readme

diff --git a/feedback_gitlab/lib/src/feedback_gitlab.dart b/feedback_gitlab/lib/src/feedback_gitlab.dart
@@ -5,7 +5,9 @@ import 'package:flutter/foundation.dart';
 import 'package:http/http.dart' as http;
 import 'package:http_parser/http_parser.dart';
 
-extension BetterFeedbackX on FeedbackData {
+/// This is an extension to make it easier to call
+/// [showAndUploadToGitLab].
+extension BetterFeedbackX on FeedbackController {
   /// Example usage:
   /// ```dart
   /// import 'package:feedback_gitlab/feedback_gitlab.dart';
@@ -40,6 +42,8 @@ extension BetterFeedbackX on FeedbackData {
   }
 }
 
+/// See [BetterFeedbackX.showAndUploadToGitLab].
+/// This is just [visibleForTesting].
 @visibleForTesting
 OnFeedbackCallback uploadToGitLab({
   required String projectId,

diff --git a/feedback_gitlab/pubspec.yaml b/feedback_gitlab/pubspec.yaml
@@ -1,6 +1,6 @@
 name: feedback_gitlab
-description: A simple way to create a GitLab issues from user feedback
-version: 2.0.0+1
+description: A Flutter package for getting better feedback. It allows the user to give interactive feedback directly in the app and upload it as an issue to GitLab
+version: 2.2.0
 homepage: https://uekoetter.dev
 repository: https://github.com/ueman/feedback
 issue_tracker: https://github.com/ueman/feedback/issues
@@ -12,7 +12,7 @@ environment:
 dependencies:
   flutter:
     sdk: flutter
-  feedback: ^2.0.0
+  feedback: ^2.2.0
   http: ^0.13.0
   http_parser: ^4.0.0
 

diff --git a/feedback_sentry/CHANGELOG.md b/feedback_sentry/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 2.2.0
+
+* This update make it compatible with feedback 2.2.0
+* Improve documentation
+
 ## 2.0.0
 
 * Initial version
diff --git a/feedback_sentry/lib/feedback_sentry.dart b/feedback_sentry/lib/feedback_sentry.dart
@@ -5,12 +5,27 @@ import 'package:flutter/foundation.dart';
 import 'package:sentry/sentry.dart';
 export 'package:feedback/feedback.dart';
 
-extension SentryFeedback on FeedbackData {
-  void showAndUploadToSentry({Hub? hub}) {
-    this.show(sendToSentry(hub: hub));
+/// Extension on [FeedbackController] in order to make
+/// it easier to call [showAndUploadToSentry].
+extension SentryFeedback on FeedbackController {
+  /// This method opens the feedback ui and the users feedback
+  /// is uploaded to Sentry after the user submitted his feedback.
+  /// [name] and [email] are optional. They are shown in the Sentry.io ui.s
+  void showAndUploadToSentry({
+    Hub? hub,
+    String? name,
+    String? email,
+  }) {
+    this.show(sendToSentry(
+      hub: hub,
+      name: name,
+      email: email,
+    ));
   }
 }
 
+/// See [SentryFeedback.showAndUploadToSentry].
+/// This is just [visibleForTesting].
 @visibleForTesting
 OnFeedbackCallback sendToSentry({
   Hub? hub,

diff --git a/feedback_sentry/pubspec.yaml b/feedback_sentry/pubspec.yaml
@@ -1,7 +1,9 @@
 name: feedback_sentry
-description: A simple way to to send user feedback with images to Sentry.io
-version: 2.0.0
-homepage: https://uekoetter.dev/
+description: A Flutter package for getting better feedback. It allows the user to give interactive feedback directly in the app and upload it to Sentry.io
+version: 2.2.0
+homepage: https://uekoetter.dev
+repository: https://github.com/ueman/feedback
+issue_tracker: https://github.com/ueman/feedback/issues
 
 environment:
   sdk: ">=2.12.0 <3.0.0"
@@ -10,7 +12,7 @@ environment:
 dependencies:
   flutter:
     sdk: flutter
-  feedback: ^2.0.0
+  feedback: ^2.2.0
   sentry: ^6.0.0
 
 dev_dependencies: