This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
get rid of rubygem-bundler as run-time requirement #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we install bundler gem under vendor/bundle/ruby/2.1.0 directory, and since we had that directory as GEM_PATH in the vhost configuration, we don't need rubygem-bundler rpm as a runtime requirement. Bundler does not install itself if you add it at the Gemfile, thus we need to install it with "gem install --install-dir ..."
|
It turned out to be much simpler than what I expected ... |
| @@ -81,6 +79,10 @@ APPLICATION_CSS=$(find . -name application-*.css 2>/dev/null) | |||
| cp $APPLICATION_CSS public/landing.css | |||
|
|
|||
| bundle install --retry=3 --local --deployment | |||
|
LGTM, I just made a small comment. |
jordimassaguerpla
added a commit
that referenced
this pull request
Aug 18, 2015
get rid of rubygem-bundler as run-time requirement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we install bundler gem under vendor/bundle/ruby/2.1.0 directory,
and since we had that directory as GEM_PATH in the vhost configuration,
we don't need rubygem-bundler rpm as a runtime requirement.
Bundler does not install itself if you add it at the Gemfile, thus we
need to install it with "gem install --install-dir ..."