Skip to content

Commit

Permalink
choose a particular directory test-integration
Browse files Browse the repository at this point in the history
  • Loading branch information
deads2k committed Aug 26, 2016
1 parent 6eb279e commit 5c9df66
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 9 deletions.
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,15 @@ check test: generated_files

# Build and run integration tests.
#
# Args:
# WHAT: Directory names to test. All *_test.go files under these
# directories will be run. If not specified, "everything" will be tested.
#
# Example:
# make test-integration
.PHONY: test-integration
test-integration: generated_files
hack/make-rules/test-integration.sh
hack/make-rules/test-integration.sh $(WHAT)

# Build and run end-to-end tests.
#
Expand Down
6 changes: 3 additions & 3 deletions hack/make-rules/test-integration.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ KUBE_TEST_ARGS=${KUBE_TEST_ARGS:-}
kube::test::find_integration_test_dirs() {
(
cd ${KUBE_ROOT}
find test/integration -name '*_test.go' -print0 \
find test/integration/${1-} -name '*_test.go' -print0 \
| xargs -0n1 dirname \
| sort -u
)
Expand All @@ -60,7 +60,7 @@ runTests() {
# TODO: Re-enable race detection when we switch to a thread-safe etcd client
# KUBE_RACE="-race"
make -C "${KUBE_ROOT}" test \
WHAT="$(kube::test::find_integration_test_dirs | paste -sd' ' -)" \
WHAT="$(kube::test::find_integration_test_dirs ${2-} | paste -sd' ' -)" \
KUBE_GOFLAGS="${KUBE_GOFLAGS:-} -tags 'integration no-docker'" \
KUBE_RACE="" \
KUBE_TIMEOUT="${KUBE_TIMEOUT}" \
Expand Down Expand Up @@ -90,5 +90,5 @@ fi
# Convert the CSV to an array of API versions to test
IFS=';' read -a apiVersions <<< "${KUBE_TEST_API_VERSIONS}"
for apiVersion in "${apiVersions[@]}"; do
runTests "${apiVersion}"
runTests "${apiVersion}" "${1-}"
done
13 changes: 8 additions & 5 deletions hack/test-integration.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,17 @@ set -o pipefail

KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..

# For help output
ARGHELP=""
if [[ "$#" -gt 0 ]]; then
ARGHELP="WHAT='$@'"
fi

echo "NOTE: $0 has been replaced by 'make test-integration'"
echo
echo "The equivalent of this invocation is: "
echo " make test-integration"
echo
echo
echo make --no-print-directory -C "${KUBE_ROOT}" test-integration
echo " make test-integration ${ARGHELP}"
echo
echo
make --no-print-directory -C "${KUBE_ROOT}" test-integration
make --no-print-directory -C "${KUBE_ROOT}" test-integration WHAT="$*"

0 comments on commit 5c9df66

Please sign in to comment.