forked from slic3r/Slic3r
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed regression causing skirt_height to he honored incorrectly when …
…printing more than one object. Includes regression test slic3r#1200
- Loading branch information
Showing
5 changed files
with
56 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
use Test::More tests => 1; | ||
use strict; | ||
use warnings; | ||
|
||
BEGIN { | ||
use FindBin; | ||
use lib "$FindBin::Bin/../lib"; | ||
} | ||
|
||
use List::Util qw(first); | ||
use Slic3r; | ||
use Slic3r::Test; | ||
|
||
{ | ||
my $config = Slic3r::Config->new_from_defaults; | ||
$config->set('skirts', 1); | ||
$config->set('skirt_height', 2); | ||
$config->set('perimeters', 0); | ||
$config->set('perimeter_speed', 99); | ||
$config->set('cooling', 0); # to prevent speeds to be altered | ||
$config->set('first_layer_speed', '100%'); # to prevent speeds to be altered | ||
|
||
my $test = sub { | ||
my ($conf) = @_; | ||
$conf ||= $config; | ||
|
||
my $print = Slic3r::Test::init_print(['20mm_cube','20mm_cube'], config => $config); | ||
|
||
my %layers_with_skirt = (); # Z => $count | ||
Slic3r::GCode::Reader->new(gcode => Slic3r::Test::gcode($print))->parse(sub { | ||
my ($self, $cmd, $args, $info) = @_; | ||
|
||
if (defined $self->Z) { | ||
$layers_with_skirt{$self->Z} //= 0; | ||
$layers_with_skirt{$self->Z} = 1 | ||
if $info->{extruding} && ($args->{F} // $self->F) == $config->perimeter_speed*60; | ||
} | ||
}); | ||
fail "wrong number of layers with skirt" | ||
unless (grep $_, values %layers_with_skirt) == $config->skirt_height; | ||
}; | ||
|
||
ok $test->(), "skirt_height is honored when printing multiple objects too"; | ||
} | ||
|
||
__END__ |