Skip to content

Commit

Permalink
pnpbios: bail out on strange errors
Browse files Browse the repository at this point in the history
A small number of systems respond to PnP dock queries with bogus values.
This causes us to keep logging an error every 2 seconds. Instead of trying
again just assume the BIOS is crapware and doesn't actually have dock
functionality.

Signed-off-by: Alan Cox <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Alan Cox authored and gregkh committed Jan 25, 2015
1 parent f989e55 commit 625505b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/pnp/pnpbios/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@ static int pnp_dock_thread(void *unused)
break;
default:
pnpbios_print_status("pnp_dock_thread", status);
continue;
printk(KERN_WARNING "PnPBIOS: disabling dock monitoring.\n");
complete_and_exit(&unload_sem, 0);
}
if (d != docked) {
if (pnp_dock_event(d, &now) == 0) {
Expand Down

0 comments on commit 625505b

Please sign in to comment.