Skip to content

Commit

Permalink
daemon: Provide missing argument for logerror() call.
Browse files Browse the repository at this point in the history
Could cause a crash if --base-path set.  Unlikely to be a security the
concern: message doesn't go to the client, so we can't leak anything
(except by dumping core), and we've already forked, so it's not a denial
of service.

Signed-off-by: Mark Wooding <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
distorted-mdw authored and Junio C Hamano committed Feb 4, 2006
1 parent c0c74a8 commit 1fda3d5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion daemon.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ static char *path_ok(char *dir)
static char rpath[PATH_MAX];
if (*dir != '/') {
/* Forbid possible base-path evasion using ~paths. */
logerror("'%s': Non-absolute path denied (base-path active)");
logerror("'%s': Non-absolute path denied (base-path active)", dir);
return NULL;
}
snprintf(rpath, PATH_MAX, "%s%s", base_path, dir);
Expand Down

0 comments on commit 1fda3d5

Please sign in to comment.