Skip to content

Commit

Permalink
refactor(migrations): remove unused version 16 migrations (angular#51926
Browse files Browse the repository at this point in the history
)

When updating to version 17, version 16 migrations cannot be executed thus making them redundant to have in the package.

PR Close angular#51926
  • Loading branch information
alan-agius4 authored and dylhunn committed Sep 27, 2023
1 parent c7127b9 commit e66c18f
Show file tree
Hide file tree
Showing 14 changed files with 1 addition and 851 deletions.
2 changes: 0 additions & 2 deletions packages/core/schematics/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ pkg_npm(
visibility = ["//packages/core:__pkg__"],
deps = [
"//packages/core/schematics/migrations/block-template-entities:bundle",
"//packages/core/schematics/migrations/guard-and-resolve-interfaces:bundle",
"//packages/core/schematics/migrations/remove-module-id:bundle",
"//packages/core/schematics/ng-generate/standalone-migration:bundle",
],
)
12 changes: 1 addition & 11 deletions packages/core/schematics/migrations.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
{
"schematics": {
"migration-v16-remove-module-id": {
"version": "16.0.0",
"description": "As of Angular v16, the `moduleId` property of `@Component` is deprecated as it no longer has any effect.",
"factory": "./migrations/remove-module-id/bundle"
},
"migration-v16-guard-and-resolve-interfaces": {
"version": "16.0.0",
"description": "In Angular version 15.2, the guard and resolver interfaces (CanActivate, Resolve, etc) were deprecated. This migration removes imports and 'implements' clauses that contain them.",
"factory": "./migrations/guard-and-resolve-interfaces/bundle"
},
"migration-v17-block-template-entities": {
"version": "17.0.0-0",
"version": "17.0.0",
"description": "Angular v17 introduces a new control flow syntax that uses the @ and } characters. This migration replaces the existing usages with their corresponding HTML entities.",
"factory": "./migrations/block-template-entities/bundle"
}
Expand Down
11 changes: 0 additions & 11 deletions packages/core/schematics/migrations/google3/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,13 @@ ts_library(
srcs = glob(["**/*.ts"]),
tsconfig = "//packages/core/schematics:tsconfig.json",
deps = [
"//packages/core/schematics/migrations/guard-and-resolve-interfaces",
"//packages/core/schematics/utils",
"//packages/core/schematics/utils/tslint",
"@npm//tslint",
"@npm//typescript",
],
)

esbuild(
name = "guard_and_resolve_interfaces_cjs",
entry_point = ":guardAndResolveInterfacesRule.ts",
format = "cjs",
output = "guardAndResolveInterfacesCjsRule.js",
platform = "node",
deps = [":google3"],
)

esbuild(
name = "wait_for_async_rule_cjs",
entry_point = ":waitForAsyncRule.ts",
Expand All @@ -34,7 +24,6 @@ esbuild(
filegroup(
name = "google3_cjs",
srcs = [
":guard_and_resolve_interfaces_cjs",
":wait_for_async_rule_cjs",
],
visibility = ["//packages/core/schematics/test/google3:__pkg__"],
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit e66c18f

Please sign in to comment.