Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format GB cell numbers as 07xxx xxxxxx #144

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

fiznool
Copy link
Contributor

@fiznool fiznool commented Jan 22, 2020

As mentioned in #123, GB mobile numbers are not currently valid.

This PR changes the generator to create numbers in the format 07xxx xxxxxx.

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #144 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage      94%   93.96%   -0.05%     
==========================================
  Files          94       94              
  Lines        2253     2253              
  Branches      317      317              
==========================================
- Hits         2118     2117       -1     
- Misses        135      136       +1
Impacted Files Coverage Δ
api/1.1/data/FI/inject.js 91.66% <0%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e221b...5450413. Read the comment docs.

@keitharm keitharm merged commit bb950da into RandomAPI:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants