Change DiagnosticInfo to base0D #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tentative merge, I'll try it out for a bit and will see in the future how it holds up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normal texts of text documents (txt / README / Latex) usually use base05 (white) color. The DiagnosticInfo is using base05, too. When I use the grammar LSP such as
ltex-ls, the inline diagnostic message is hard to identify. Following image shows the example (inbase-tomorrow-nightcolorscheme):After change to base0D (Blue):
The normal texts are not special keywords. The diagnostic message will be overwhelmed by long normal texts. Changes to base0D can make the diagnostic message more clear.