Ensure deploy is owned by user #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanb2
force-pushed
the
topic-ensure-deploy-is-owned-by-user
branch
from
789e91a
to
3a55312
Compare
Switch "docker cp" to tar streaming mode. As the receiving "tar" command is executed outside Docker the resulting directories & files are owned by the calling user.
stefanb2
force-pushed
the
topic-ensure-deploy-is-owned-by-user
branch
from
3a55312
to
948a285
Compare
|
Seems okay. Shall I merge or are you still making changes? |
Please go ahead and merge. Thank you. |
|
Github says no. Another day. |
martignoni
added a commit
to moodlebox/pi-gen-moodlebox
that referenced
this pull request
Mar 31, 2023
* Fix apt gpg key install * export-image: change boot partition lable to 'bootfs' Fixes RPi-Distro#669 * Update release notes * Check that docker is not set up in rootless mode (RPi-Distro#679) Mounting binfmt_misc inside the container requires root rights. If "docker info" indicates rootless mode then fall back to "sudo docker". Allow the user to override the docker command with the DOCKER by setting the environment variable. * Ensure that deploy is always owned by user (RPi-Distro#680) Switch "docker cp" to tar streaming mode. As the receiving "tar" command is executed outside Docker the resulting directories & files are owned by the calling user. * DRY removal for docker run command line (RPi-Distro#686) Factor out the differences into variables so that there is only one implementation of the "docker run" command line to maintain. * Use tmpfs for chroot /run and /tmp --------- Co-authored-by: Serge Schneider <[email protected]> Co-authored-by: Stefan Becker <[email protected]>
SRaus
pushed a commit
to analogdevicesinc/adi-kuiper-gen
that referenced
this pull request
Jun 6, 2023
Switch "docker cp" to tar streaming mode. As the receiving "tar" command is executed outside Docker the resulting directories & files are owned by the calling user.
wandering-andy
pushed a commit
to wandering-andy/pi-gen
that referenced
this pull request
Oct 15, 2023
Switch "docker cp" to tar streaming mode. As the receiving "tar" command is executed outside Docker the resulting directories & files are owned by the calling user.
kayhannay
pushed a commit
to kayhannay/efalive_pi
that referenced
this pull request
Feb 12, 2024
Switch "docker cp" to tar streaming mode. As the receiving "tar" command is executed outside Docker the resulting directories & files are owned by the calling user.
UmeshMohan-Dozee
pushed a commit
to DozeeRnD/pi-gen
that referenced
this pull request
Sep 18, 2024
Switch "docker cp" to tar streaming mode. As the receiving "tar" command is executed outside Docker the resulting directories & files are owned by the calling user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files copied out by
sudo docker cp ...are owned byrootand not the calling user.Update the
build-docker.shto use tar streaming mode instead. As the receivingtarcommand is executed outside Docker the resulting directories & files are owned by the calling user. Hence you no longer need to usesudo rm -rf deployto remove it.