Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a single partitioned loop device #641

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

rfc6919
Copy link
Contributor

@rfc6919 rfc6919 commented Oct 22, 2022

per #639, use a single partitioned loop device rather than multiple devices with offset/length.

testing is limited to "works for me, and doesn't leave any new errors in the output of build.sh". is there an actual test suite or anything like that?

@XECDesign
Copy link
Member

I've merged this into the internal nightly build system. If it doesn't cause any issues, I'll merge the PR in a few days.

Thanks!

@XECDesign
Copy link
Member

Pushed a couple of fixes.

unmount_image returns false and halts the whole build if the image isn't mounted in the first place. Adding the if statement back rather than using && should fix that.

Then if the loopback device is attached but the either partition is not mounted, you get umount: /dev/loopXpN: not mounted. and again, false is returned.

If the mounted partitions have subdirectories mounted, then umount isn't enough. Maybe an a recursive umount would be fine, but there's already an unmount option which should do the right thing.

I've also changed it to iterate over all the partitions rather than assuming there are only two.

@XECDesign XECDesign merged commit 1d13a29 into RPi-Distro:master Nov 11, 2022
@XECDesign
Copy link
Member

Seems to work now, thanks.

martignoni added a commit to moodlebox/pi-gen-moodlebox that referenced this pull request Nov 11, 2022
…i-Distro-master

* 'master' of https://github.com/RPi-Distro/pi-gen:
  use a single partitioned loop device (RPi-Distro#641)
  Add parameter to keep cap_setfcap
  Updates to avoid common pitfalls when changing the RELEASE variable
  stage2: pre-install kms++-utils
  apt/retries: specify option from the Acquire group (RPi-Distro#638)
  Update README.md document WPA_COUNTRY Code format (RPi-Distro#636)
  Update release notes
  Disable first run wizard if DISABLE_FIRST_BOOT_USER_RENAME is set
  Update release notes
  Update release notes
  nodered is no longer included in full images
martignoni added a commit to moodlebox/pi-gen-moodlebox that referenced this pull request Nov 11, 2022
* RPi-Distro-master:
  use a single partitioned loop device (RPi-Distro#641)
  Add parameter to keep cap_setfcap
  Updates to avoid common pitfalls when changing the RELEASE variable
  stage2: pre-install kms++-utils
  apt/retries: specify option from the Acquire group (RPi-Distro#638)
  Update README.md document WPA_COUNTRY Code format (RPi-Distro#636)
  Update release notes
  Disable first run wizard if DISABLE_FIRST_BOOT_USER_RENAME is set
  Update release notes
  Update release notes
  nodered is no longer included in full images
mcm001 pushed a commit to PhotonVision/photon-pi-gen that referenced this pull request Jan 25, 2023
wandering-andy pushed a commit to wandering-andy/pi-gen that referenced this pull request Oct 15, 2023
UmeshMohan-Dozee pushed a commit to DozeeRnD/pi-gen that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants