Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect shfl_xor for Windows #1925

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix incorrect shfl_xor for Windows #1925

merged 1 commit into from
Mar 10, 2020

Conversation

skyreflectedinmirrors
Copy link
Contributor

copy/paste error, need __shfl_xor w/ lane_mask

Fix incorrect shfl_xor for Windows
09edc7e 
copy/paste error, need __shfl_xor w/ lane_mask
@emankov
Copy link
Contributor

emankov commented Mar 10, 2020

Duplicate of #1923

@emankov emankov marked this as a duplicate of #1923 Mar 10, 2020
@dmcdougall
Copy link

Hmmm. Those two patches are not the same. Is there a fundamental difference between _down and _xor?

@skyreflectedinmirrors
Copy link
Contributor Author

Good catch @dmcdougall -- @emankov, I left a review for the fix

@emankov
Copy link
Contributor

emankov commented Mar 10, 2020

2 copy-paste typos )

@emankov emankov reopened this Mar 10, 2020
@emankov emankov self-requested a review March 10, 2020 19:18
@emankov emankov mentioned this pull request Mar 10, 2020
Closed
@emankov emankov merged commit f98ce58 into ROCm:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emankov emankov emankov approved these changes

Assignees
No one assigned
Labels
hip type:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyreflectedinmirrors @emankov @dmcdougall