Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIPIFY][cmake] Packaging for hipify-clang #1795

Merged
merged 1 commit into from
Jan 20, 2020
Merged

[HIPIFY][cmake] Packaging for hipify-clang #1795

merged 1 commit into from
Jan 20, 2020

Conversation

aakanksha555
Copy link
Contributor

Package selects the correct CMAKE_VERSION depending on the type of build:

  • If hipify-clang is built along with HIP, it uses the HIP_VERSION (cmake produces a .hipversion file when HIP is built, extracting the HIP_VERSION data from it)
  • If hipify-clang is built stand-alone, it uses the LLVM version.

emankov
emankov approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@emankov emankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if it finally works

@aakanksha555
Copy link
Contributor Author

LGTM, if it finally works

Yeah, packages are generated with proper version now.

@aakanksha555
Copy link
Contributor Author

Merging is blocked for me, what should be done about it?

@emankov emankov merged commit 955b88e into ROCm:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emankov emankov emankov approved these changes

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

Assignees
No one assigned
Labels
hipify type:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aakanksha555 @emankov @aaronenyeshi