This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
add brief section to readme about building docker images #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chazu can you add instruction on how to modify docker-compose to use self-built images? |
Adds instructions on building images via their inclusion in a `docker-compose.yml` and adds clarification on images which require building locally before docker images will build.
|
Awesome! |
isido993
pushed a commit
that referenced
this pull request
Sep 19, 2019
add brief section to readme about building docker images
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @sochix suggestion in #247 - This PR provides a short section in the README on how to build the docker images. It doesn't lay out the specifics for each image, but I can add more detail if you like.
Let me know what other changes you prefer before merge, or feel free to tweak the doc.
Thanks!