[1.6.0] Upgrade mapset filtering system #4154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AiAe
changed the title
AiAe
changed the title
…for unranked maps instead of searching for content containing 'unranked'
Cache the search keyword trie and dictionary to speed up parsing process.
WilliamQiufeng
force-pushed
the
new-search-parser
branch
from
571feab
to
4d0fdf8
Compare
AiAe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4146
It uses a simple parser I wrote which you can find here. It's referenced as a NuGet package. It is unit tested, covering 98% of the codebase, where the rest uncovered ones are the exposed public getters.
Searching for maps whose creator contains
piano:Searching for maps whose creator doesn't contain
piano, length less than 2 minutes, difficulty < 20:Extra features
unranked/unsubmittedwill search for unranked and unsubmitted maps, instead of looking for maps with contentunranked/unsubmitted.