Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test lemke howson exceptions #323

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Test lemke howson exceptions #323

merged 2 commits into from
Aug 17, 2017

Conversation

QBatista
Copy link
Member

@QBatista QBatista commented Aug 9, 2017

Added tests for exceptions to lemke_howson.py and raise type error when init_pivot type is not an integer instance.

Fix #302

@coveralls
Copy link

coveralls commented Aug 9, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 92.631% when pulling b24128d on QBatista:test-lemke_howson-exceptions into 64d964c on QuantEcon:master.

oyamad
oyamad approved these changes Aug 9, 2017
View reviewed changes
Copy link
Member

@oyamad oyamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@mmcky
Copy link
Contributor

mmcky commented Aug 9, 2017 •
edited
Loading

thanks for the PR @QBatista and for the review @oyamad.
I will leave this PR open for one more day for comment and then will merge.

It appears that travis is in fact green and passing but the web integration isn't updating.

@mmcky
Copy link
Contributor

mmcky commented Aug 17, 2017

I reset travis and now showing green so will merge. Thanks again @QBatista and @oyamad

@mmcky mmcky merged commit 188e5ba into QuantEcon:master Aug 17, 2017
@QBatista QBatista deleted the test-lemke_howson-exceptions branch September 23, 2017 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyamad oyamad oyamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QBatista @coveralls @mmcky @oyamad