Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exec refacto #516

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Exec refacto #516

merged 1 commit into from
Dec 2, 2021

Conversation

erebe
Copy link
Collaborator

@erebe erebe commented Dec 2, 2021 •
edited
Loading

  • Remove SimpleError and introduce a proper error
  • Encapsulate commands
  • Re-use exec_with_timeout for exec_with_output
  • Simplify lambda to capture stdout/stderr from Result<String, Error> to String

@erebe erebe force-pushed the exec_refacto branch 2 times, most recently from a610281 to 5f0e352 Compare December 2, 2021 09:57
@erebe erebe merged commit 11271ad into dev Dec 2, 2021
@erebe erebe deleted the exec_refacto branch December 2, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminch benjaminch benjaminch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erebe @benjaminch