Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax now-unneeded constraints #8968

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Conversation

jakelishman
Copy link
Member

Summary

These were added in #7174 and #7815. Both Matplotlib and Sphinx have been updated several times since then, and should now be compatible.

Details and comments

@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Oct 20, 2022
@jakelishman jakelishman requested a review from a team as a code owner October 20, 2022 12:56
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Oct 20, 2022

Pull Request Test Coverage Report for Build 3290571596

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 142 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 84.57%

Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 79.78%
qiskit/pulse/library/waveform.py 3 91.49%
src/results/marginalization.rs 29 71.84%
src/sampled_exp_val.rs 49 6.56%
src/sabre_swap/mod.rs 59 80.94%
Totals Coverage Status
Change from base Build 3290531884: -0.2%
Covered Lines: 61818
Relevant Lines: 73097

💛 - Coveralls

@mergify mergify bot merged commit 65851b4 into Qiskit:main Oct 20, 2022
@jakelishman jakelishman deleted the relax-constraints branch October 30, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants