Pin cvxpy to known-good version
#10997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some diamond-norm tests are failing with the latest 1.4.0 release of cvxpy. Given the complex optimisation problem that the dnorm represents, it's quite possible that randomised tests would already have had a low success rate, and this is just a case of some internal tweaks destabilising the particular operator choice in our test.
jakelishman
added
type: qa
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6467869439
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
Some diamond-norm tests are failing with the latest 1.4.0 release of cvxpy. Given the complex optimisation problem that the dnorm represents, it's quite possible that randomised tests would already have had a low success rate, and this is just a case of some internal tweaks destabilising the particular operator choice in our test. (cherry picked from commit 337832e)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
Some diamond-norm tests are failing with the latest 1.4.0 release of cvxpy. Given the complex optimisation problem that the dnorm represents, it's quite possible that randomised tests would already have had a low success rate, and this is just a case of some internal tweaks destabilising the particular operator choice in our test. (cherry picked from commit 337832e) Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some diamond-norm tests are failing with the latest 1.4.0 release of cvxpy. Given the complex optimisation problem that the dnorm represents, it's quite possible that randomised tests would already have had a low success rate, and this is just a case of some internal tweaks destabilising the particular operator choice in our test.
Details and comments
Hopefully should get CI running again.