Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create new session in from_id() #1896

Merged
merged 10 commits into from
Sep 4, 2024
Merged

Don't create new session in from_id() #1896

merged 10 commits into from
Sep 4, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Aug 29, 2024

Summary

Session.from_id() calls the POST /Session endpoint which is unnecessary because the session and session id already exist

Details and comments

Fixes #1895

@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Aug 29, 2024
@kt474 kt474 requested a review from ptristan3 August 29, 2024 18:38
@ptristan3
Copy link
Collaborator

Could you add tests to ensure the new_session param works properly?

SamFerracin
SamFerracin approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@SamFerracin SamFerracin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a comment that we should probably clean Session up in future iterations

@kt474 kt474 merged commit 3032b9a into Qiskit:main Sep 4, 2024
18 checks passed
@kt474 kt474 deleted the session-from-id-post branch September 4, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptristan3 ptristan3 ptristan3 approved these changes

@SamFerracin SamFerracin SamFerracin approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting the details of an existing sessions submits a new session
3 participants
@kt474 @ptristan3 @SamFerracin