Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple cycles of staggered DD #1630

Merged
merged 3 commits into from
May 6, 2024
Merged

Fix multiple cycles of staggered DD #1630

merged 3 commits into from
May 6, 2024

Conversation

dieris
Copy link
Contributor

@dieris dieris commented Apr 19, 2024

Summary

Update the insert_multiple_cycles option to support staggered DD pulses.

@coveralls
Copy link

coveralls commented Apr 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8973081044

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 83.713%
Totals Coverage Status
Change from base Build 8972794837: 0.009%
Covered Lines: 6281
Relevant Lines: 7503
💛 - Coveralls

kt474
kt474 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably best for someone else to review as well

@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Apr 24, 2024
@kt474 kt474 added this to the 0.24.0 milestone Apr 24, 2024
@kt474 kt474 merged commit 5030bda into Qiskit:main May 6, 2024
20 checks passed
@t-imamichi t-imamichi mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt474 kt474 kt474 approved these changes

Assignees

@samanthavbarron samanthavbarron

Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dieris @coveralls @kt474 @samanthavbarron