Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs publishing job #1589

Merged
merged 7 commits into from
Mar 8, 2023
Merged

Add docs publishing job #1589

merged 7 commits into from
Mar 8, 2023

Conversation

mtreinish
Copy link
Member

@mtreinish mtreinish commented Aug 31, 2022

Summary

This commit adds a new CI job for publishing documentation on release.
Now that qiskit-aer is a self contained package with it's own namespace
the documentation build no longer needs to be combined into the main
qiskit docs anymore. As such this commit will enable aer ci to publish
built documentation for the project to:

https://qiskit.org/documentation/aer

on every release.

Details and comments

Fixes Qiskit/qiskit#1508

This commit adds a new CI job for publishing documentation on release.
Now that qiskit-aer is a self contained package with it's own namespace
the documentation build no longer needs to be combined into the main
qiskit docs anymore. As such this commit will enable aer ci to publish
built documentation for the project to:

https://qiskit.org/documentation/aer

on every release.
mtreinish added a commit to mtreinish/qiskit that referenced this pull request Aug 31, 2022
This commit adds the qiskit aer documentation to the other builds path.
This will let qiskit-aer manage publishing its own documentation to
https://qiskit.org/documentation/aer
Starting in the pending 0.11.0 qiskit-aer release it has moved to its
own python package/namespace qiskit_aer which will complicate the
publishing the documentation under the same build as the qiskit main
docs. So aer is moving to publishing it's own doc page in
Qiskit/qiskit-aer#1589
@jakelishman
Copy link
Member

If we're publishing it separately this time round, we probably need to run through the whole documentation adding intersphinx to Terra, and making sure the monkey-patched QuantumCircuit methods are still getting documented.

@mtreinish
Copy link
Member Author

Well I was more concerned about how the main docs build will deal with the new namespace. I guess it would work fine and just build the pages as stubs/qiskit_aer.* instead of stubs/qiskit.providers.aer.* and it should work fine. Maybe lets hold off on this until after we remove aer from the metapackage and update Qiskit/qiskit#1596 to redirect in the same docs build. What do you think?

@jakelishman
Copy link
Member

I'm mostly concerned with the things like QuantumCircuit.save_statevector that aren't going to be the target of any autosummary directive any more after the move (previously Terra's qiskit.circuit module would have pulled them in as they'd be attached to QuantumCircuit during the build process), and I'm worried about any places in the Aer documentation that might link to Terra objects (e.g. :class:`.QuantumCircuit` will fail in a separate build).

I think the stubs that are generated by the Aer build itself should work, as you say.

@jakelishman
Copy link
Member

Happy to hold off on making changes to the documentation build process til later - we don't necessarily need to hold Aer 0.11 on that.

mergify bot pushed a commit to Qiskit/qiskit-metapackage that referenced this pull request Sep 2, 2022
This commit adds the qiskit aer documentation to the other builds path.
This will let qiskit-aer manage publishing its own documentation to
https://qiskit.org/documentation/aer
Starting in the pending 0.11.0 qiskit-aer release it has moved to its
own python package/namespace qiskit_aer which will complicate the
publishing the documentation under the same build as the qiskit main
docs. So aer is moving to publishing it's own doc page in
Qiskit/qiskit-aer#1589
@hhorii hhorii added this to the Aer 0.12.0 milestone Nov 15, 2022
@hhorii
Copy link
Collaborator

hhorii commented Mar 7, 2023

We need to change a branch protection rule from "docs (3.7)" to "docs (3.8)".

Copy link
Collaborator

@hhorii hhorii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. After this PR is merged, we need some follow up PRs to add missing APIs (such as QuantumCircuit.save_*) and more contents.

@hhorii hhorii merged commit d3a05ba into Qiskit:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aer needs its own documentation page
3 participants