Remove duplicate build of aer from tutorials job #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent release of pip 21.3 the method of how in-repo builds was changed to be done in place. This change caused a conflict with how the tutorial jobs were setup where they were building aer twice inadvertently, once to build the package and a second time to build the binaries in place in the source for when the notebooks are executed. This second step wasn't necessary originally and was masking the real issue (the conflict with qiskit/ in the working dir and the python env). However, now that we're building binaries in place this is coming to a head. This commit attempts to fix the issue by removing the second build since it's not necessary, if we still have issues after this change we can just run the tutorial from a different working directory and it should use the prior build.
chriseclectic
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the recent release of pip 21.3 the method of how in-repo builds was
changed to be done in place. This change caused a conflict with how the
tutorial jobs were setup where they were building aer twice
inadvertently, once to build the package and a second time to build the
binaries in place in the source for when the notebooks are executed.
This second step wasn't necessary originally and was masking the real
issue (the conflict with qiskit/ in the working dir and the python env).
However, now that we're building binaries in place this is coming to a
head. This commit attempts to fix the issue by removing the second build
since it's not necessary, if we still have issues after this change we
can just run the tutorial from a different working directory and it
should use the prior build.
Details and comments