Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests:ParameterEstimationComposition #2753

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Jul 28, 2023

Reduce running time.
Provide expected results for different optimization methods

@jvesely jvesely added the tests Test changes label Jul 28, 2023
@jvesely jvesely requested a review from davidt0x July 28, 2023 15:04
@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

Copy link
Collaborator

@davidt0x davidt0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…by 40x

It's still enough to recover the parameters and reduces test time
significantly.

Signed-off-by: Jan Vesely <[email protected]>
@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@jvesely jvesely merged commit c49c015 into PrincetonUniversity:devel Jul 31, 2023
31 checks passed
@jvesely jvesely deleted the pec branch July 31, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants