llvm: Implement compiled Angle and SoftMax derivative Functions #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Vesely <[email protected]>
Signed-off-by: Jan Vesely <[email protected]>
PTX can't select llvm intrinsics, use builtin wrapper functions. Signed-off-by: Jan Vesely <[email protected]>
Signed-off-by: Jan Vesely <[email protected]>
…vative function Signed-off-by: Jan Vesely <[email protected]>
This will allow generating softmax with different output type than the one set by the SoftMax Function instance. Signed-off-by: Jan Vesely <[email protected]>
Signed-off-by: Jan Vesely <[email protected]>
jvesely
changed the title
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
jvesely
added a commit
that referenced
this pull request
Nov 11, 2022
PR #2528 introduced two breaking changes 1.) Renamed ReLU's derivative argument 'input'->'variable' which broke existing users of ReLU derivative. 2.) Changed SoftMax derivative calculation to use 'input' instead of 'output'. This is incorrect as the algorithm reuses existing outputs to calculate derivative results. Both are restored to their original form. Moreover, a single input codepath is added to SoftMax, calculating results if they are not provided. The compiled version and tests are adjusted accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to fixed implementation of ReLU derivative in both Python and compiled variant.
Use input consistently in SoftMax derivative (Python).
Add sin and cos builtin functions, PTX can't select instructions for llvm.sin/llvm.cos opcodes.