Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

displayHeader hook only affect Front Office pages #1568

Merged
merged 1 commit into from
Nov 9, 2022
Merged

displayHeader hook only affect Front Office pages #1568

merged 1 commit into from
Nov 9, 2022

Conversation

leemyongpakvn
Copy link
Contributor

@leemyongpakvn leemyongpakvn commented Nov 8, 2022 •
edited by matks
Loading

Questions Answers
Branch? 8.x
Description? Maybe we need to note use displayBackOfficeHeader for Back Office pages somewhere in the docs
Fixed ticket? Fixes #{issue number here} if there is a related issue

@github-actions github-actions bot added the 8.x label Nov 8, 2022
matks
matks approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @leemyongpakvn

@matks matks merged commit d0ce7a2 into PrestaShop:8.x Nov 9, 2022
@matks
Copy link
Contributor

matks commented Nov 9, 2022

@leemyongpakvn do you think you can provide a backport PR for 1.7.x branch ? :)

@leemyongpakvn
Copy link
Contributor Author

leemyongpakvn commented Nov 9, 2022 •
edited
Loading

@matks Certainly, done ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@mflasquin mflasquin mflasquin approved these changes

Assignees
No one assigned
Labels
8.x Backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leemyongpakvn @matks @mflasquin